Fixed support for external data format #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomWildenhain-Microsoft
force-pushed
the
tom/onnx2pylargemodel
branch
2 times, most recently
from
a0a1173 to
c2644f4
Compare
TomWildenhain-Microsoft
force-pushed
the
tom/onnx2pylargemodel
branch
from
c2644f4 to
db8d375
Compare
wenbingl
approved these changes
Dec 29, 2020
| working_path = os.path.abspath(os.path.dirname(__file__)) | ||
| tmp_path = os.path.join(working_path, 'temp') | ||
| data_path = os.path.join(working_path, 'data') | ||
|
|
||
| class Oonnx2PyTests(unittest.TestCase): | ||
| def tearDown(self): | ||
| from onnxconverter_common.onnx2py import clear_directory |
There was a problem hiding this comment.
wasn't sure if this is a good practice in general, any special reason of moving it here?
There was a problem hiding this comment.
onnx2py requires onnx version > 1.3. The new from onnx import external_data_helper will make it crash when imported in lower versions. The python 5 unit tests use onnx 1.3 but are skipped for onnx2py.
There was a problem hiding this comment.
Ideally maybe onnx2py would be its own repo since its pip requirements are technically higher than onnxconverter-common's install requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.