Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly load the VS assemblies on Dev15 to fix unit test debugging #1527

Merged
merged 2 commits into from
Apr 13, 2017

Conversation

billti
Copy link
Member

@billti billti commented Apr 13, 2017

See issue description in the comment at #1524 (comment) .

This may not be the most elegant solution, or the right one long term, but it does work and is simple enough. If in the test executor process, then by loading the assemblies explicitly when it attempts to run tests, but before hitting any code that would cause .NET to try and locate the assemblies, they are already loaded when required.

@paulvanbrenk
Copy link
Contributor

We should figure out who the owner is for the exe and ask them to update the app.config.

Copy link
Contributor

@paulvanbrenk paulvanbrenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nitpicks about open { being on the wrong line, and use var instead of string.

Is there a specific reason we don't want to use Assembly.GetExecutingAssebmly and get the Location from that?

@billti
Copy link
Member Author

billti commented Apr 13, 2017

Addressed feedback.

@billti billti merged commit d431527 into master Apr 13, 2017
@billti billti deleted the billti/fixUnitTestDebugging branch April 13, 2017 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants