-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Adapter Improvements - Register test results incrementally #1430
Closed
ozyx
wants to merge
13
commits into
microsoft:test-adapter-improvements
from
ozyx:test-adapter-improvements
Closed
Test Adapter Improvements - Register test results incrementally #1430
ozyx
wants to merge
13
commits into
microsoft:test-adapter-improvements
from
ozyx:test-adapter-improvements
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @ozyx, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
Closing -- see #1524 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In this set of changes I have modified
TestExecutor
andrun_tests.js
to be able to communicate with each other viaTestEvent
objects. This is to allow the incremental logging of test results and to allow us to accurately record test duration by emittingtest start
events (or other events).The overall goal of the changes in this branch is to fix issues #518 and #1157 (test efficiency and Mocha running
before()
andafter()
hooks multiple times per test suite.)We have been using a version of these changes internally for the past month (running Mocha tests on TFS 2015 build definition) and... so far, so good. At this point I believe it is necessary to get a second pair of eyes on the code since fixing the Test Adapter issues required such a significant code change. I've been working with @mjbvz on this for the past couple of months (not sure if he is still working on
nodejstools
or not?) and through his guidance led the development of these changes.Testing
More extensive testing is certainly needed, but here is a summary of some of the cases I've tested and their current statuses. Text highlighted in bold are issues that need investigation/fixes.
Please let me know if there are any areas of the code you would like me to elaborate on, or any improvements necessary in order to get this code up to snuff for merging.