Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose native on the node-pty module again so that xterm.js can upgrade #153

Closed
Tyriar opened this issue Oct 27, 2017 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 27, 2017

Tests within xterm.js rely on .native from node-pty v0.4, as a temporary workaround so that xterm.js can move forward I want to expose .native again but not as a public API.

https://github.com/sourcelair/xterm.js/blob/8ece306dbe9c7aee13cce9c60fae74202f8660ee/src/Terminal.integration.ts#L86

@jerch I think some of your finer-grained APIs in #73 will let us remove the dependency on native. If so we should consider pulling those particular APIs in first 😃

@jerch
Copy link
Collaborator

jerch commented Oct 29, 2017

@Tyriar Well the RawPty class could be used instead, it is kinda a wrapper around all low level pty stuff on unix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants