This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge code
Merge latest code changes into Github Master (#54)
merge master
merge master
merge master
merge master
merge master
sklearn examples (#169)
merge master
* fix nnictl bug * fix nnictl create bug * add experiment status logic * add more information for nnictl * fix Evolution Tuner bug * refactor code * fix code in updater.py * fix nnictl --help * fix classArgs bug * update check response.status_code logic * show trial log path * update document * fix install.sh * set default vallue for maxTrialNum and maxExecDuration * fix nnictl * fix config path hint * support multiPhase * fix bash-completion * refactor bash-completion * add sklearn-regression * add search_space * fix bug * fix install.sh * refactor code * remove unused code * support multi experiments * fix issues
Dev multiple experiments
* fix nnictl bug * fix nnictl create bug * add experiment status logic * add more information for nnictl * fix Evolution Tuner bug * refactor code * fix code in updater.py * fix nnictl --help * fix classArgs bug * update check response.status_code logic * show trial log path * update document * fix install.sh * set default vallue for maxTrialNum and maxExecDuration * fix nnictl * fix config path hint * support multiPhase * fix bash-completion * refactor bash-completion * add sklearn-regression * add search_space * fix bug * fix install.sh * refactor code * remove unused code * support multi experiments * fix issues
* fix nnictl bug * fix nnictl create bug * add experiment status logic * add more information for nnictl * fix Evolution Tuner bug * refactor code * fix code in updater.py * fix nnictl --help * fix classArgs bug * update check response.status_code logic * show trial log path * update document * fix install.sh * set default vallue for maxTrialNum and maxExecDuration * fix nnictl * fix config path hint * support multiPhase * fix bash-completion * refactor bash-completion * add sklearn-regression * add search_space * fix bug * fix install.sh * refactor code * remove unused code * support multi experiments * fix issues * set nnictl stop require the port
chicm-ms
approved these changes
Oct 10, 2018
QuanluZhang
reviewed
Oct 10, 2018
tools/nnicmd/nnictl.py
Outdated
parser_resume.set_defaults(func=resume_experiment) | ||
|
||
# parse update command | ||
parser_updater = subparsers.add_parser('update', help='update the experiment') | ||
#add subparsers for parser_updater | ||
parser_updater_subparsers = parser_updater.add_subparsers() | ||
parser_updater_searchspace = parser_updater_subparsers.add_parser('searchspace', help='update searchspace') | ||
parser_updater_searchspace.add_argument('--port', '-p', default=51188, dest='port', help='the port of restful server') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about creating a constant variable for 51188?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, fixed in #202
QuanluZhang
approved these changes
Oct 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.