Merging dev to master for 6.5.3-preview Release #713

cheenamalhotra · 2018-06-01T18:13:53Z

No description provided.

…thub-623

…ttent failures.

Update snapshot

… old Constructor and added a new constructor with 1 param

…thub-623

…nto github-623

…d by getColumns() (#695) * Fix | getColumns() API, changed column name from SS_IS_COMPUTED to IS_AUTOINCREMENT per JDBC specs | issue #600 * Fix | getColumns() API, changed column name from SS_IS_COMPUTED to IS_GENERATEDCOLUMN per JDBC specs | issue #600

Adding Old Constructor back to AKV Provider

…API (#701) * Resolving maven warnings * Removing jreVersion property Does not make sense now that we use final name in the build itself. Only used in 1 place, hard-coding java version for different builds as that's what it represents anyways. * java warnings

resource bundle for error message strings in junit tests

HostNameInCertificate Fix

Fix for Prepared Statement handle not found intermittent exception

* Feature | Added support for JDK 10 in both Maven and Gradle - builds jre10 jars for the driver, replacing jre9 * JDK 10 | Merge 42 classes to base classes to reduce class redundancy. * JDK 10 | Attempt to run JDK 10 with Appveyor * Remove unwanted space * Updating Travis script to use JDK 10 * Testing without addons * Update script for Jacoco report to build 43 profile * Revert driver changes for 42 compliance - to be added in a separate PR * Revert Test class changes for 42 compliance - to be done in a separate PR * Reformatted code * Add ID to jacoco plugin execution task

) fix for automatic credential discarding * update felix to 3.5.0 * Revised implementation Decided to not dispose user created credentials at all. * Updated flag set location

This reverts commit 5c6ccd3.

* changes for preview release * requested changes * jre version update changes

codecov-io · 2018-06-01T18:53:06Z

Codecov Report

Merging #713 into master will decrease coverage by 0.06%.
The diff coverage is 26.19%.

@@             Coverage Diff             @@
##             master    #713      +/-   ##
===========================================
- Coverage     48.17%   48.1%   -0.07%     
+ Complexity     2585    2582       -3     
===========================================
  Files           114     113       -1     
  Lines         26578   26553      -25     
  Branches       4453    4457       +4     
===========================================
- Hits          12803   12773      -30     
- Misses        11635   11648      +13     
+ Partials       2140    2132       -8

Flag	Coverage Δ	Complexity Δ
#JDBC42	`47.98% <26.19%> (-0.11%)`	`2571 <10> (-12)`
#JDBC43	`48.04% <26.19%> (-0.08%)`	`2581 <10> (-2)`

Impacted Files	Coverage Δ	Complexity Δ
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java	`32.26% <ø> (-0.16%)`	`58 <0> (ø)`
...a/com/microsoft/sqlserver/jdbc/SQLJdbcVersion.java	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java	`45.19% <ø> (ø)`	`66 <0> (ø)`	⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java	`52.61% <0%> (-0.19%)`	`240 <0> (ø)`
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java	`59.36% <0%> (-0.19%)`	`135 <0> (ø)`
...m/microsoft/sqlserver/jdbc/KerbAuthentication.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...m/microsoft/sqlserver/jdbc/KeyVaultCredential.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
...QLServerColumnEncryptionAzureKeyVaultProvider.java	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java	`45.76% <31.25%> (+0.06%)`	`288 <0> (ø)`	⬇️
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java	`50.61% <53.12%> (-0.08%)`	`160 <10> (+3)`
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6815b08...c8e638d. Read the comment docs.

peterbae and others added 30 commits February 23, 2018 10:13

623 fix

838ddd7

623 change stash

92a164a

Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into gi…

4daa214

…thub-623

Prepared Statement Caching fix for 'handle not found' errors

5e251c9

Merge branch 'dev' into github-623

c582d76

Fix for PS Caching issue - Calling reset instead of on type def changes

bfa21eb

Updated comparison

c80c93e

Change back assert check.

7978516

Adding call to removeReference back + Fix for Batch processes intermi…

f091eff

…ttent failures.

Merge branch 'dev' into pstmt_caching

cbd3158

Removed DBName and made changes to resetPrepStmtHandle method

2909654

Check for null handle before proceed

c3365fb

Merge branch 'ms-dev' into pstmt_caching_ongit

2754d87

Merge branch 'pstmt_caching' into pstmt_caching_ongit

560c0ea

Adding Old Constrcutor back to AKV Implementation

0b1d915

Making baseURL final

43f6e91

Remove unnecessary code.

433abda

Merge branch 'dev' into pstmt_caching

e0281cb

Update snapshot

8f036b1

Merge pull request #694 from peterbae/snapshot-update

58f4f1d

Update snapshot

Merge branch 'dev' into pstmt_caching

1c32278

Merge branch 'dev' into akv-old-constructor

ab6ad0c

Feature | AKV Old Constructor changes - Reformatted code + Deprecated…

e05abee

… old Constructor and added a new constructor with 1 param

Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into gi…

7d89b06

…thub-623

Merge branch 'github-623' of https://github.com/peterbae/mssql-jdbc i…

195c601

…nto github-623

Merge branch 'dev' into akv-old-constructor

633fe83

fix issue with redirection

4b128db

Fix | PS Caching - Remove commented lines

d27677b

Merge branch 'dev' into pstmt_caching

f1789e4

cheenamalhotra and others added 19 commits May 23, 2018 15:38

Trigger Appveyor test

c48cef5

Fix | AKV Old Constructor - Calling the other constructor instead.

fc1303c

Fix | Reversed null checks

252cacd

Resolving alignment problems and comments

e3bdaec

Merge pull request #675 from cheenamalhotra/akv-old-constructor

feaa8c3

Adding Old Constructor back to AKV Provider

Applied formatter

9cb981a

Merge branch 'dev' into pstmt_caching

0ba04de

Fix | Fix some of the Javadoc warnings (#702)

cbea8bd

Merge branch 'dev' into pstmt_caching

d61f6fa

resource bundle for junit test error strings (#698)

4f1b3e1

resource bundle for error message strings in junit tests

Merge branch 'dev' into pstmt_caching

f713515

Merge pull request #644 from peterbae/github-623

eb312a0

HostNameInCertificate Fix

Merge pull request #648 from cheenamalhotra/pstmt_caching

a409708

Fix for Prepared Statement handle not found intermittent exception

Kerberos Constrained Delegation Impersonated Credential Expiry fix (#636

99a2e0f

) fix for automatic credential discarding * update felix to 3.5.0 * Revised implementation Decided to not dispose user created credentials at all. * Updated flag set location

changes for 6.5.3 preview release

5c6ccd3

Revert "changes for 6.5.3 preview release"

6a3f676

This reverts commit 5c6ccd3.

Changes in preparation for 6.5.3 preview release (#710)

c8e638d

* changes for preview release * requested changes * jre version update changes

cheenamalhotra added this to the 6.5.3 milestone Jun 1, 2018

rene-ye self-requested a review June 1, 2018 20:23

rene-ye approved these changes Jun 1, 2018

View reviewed changes

cheenamalhotra merged commit 405c704 into master Jun 1, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merging dev to master for 6.5.3-preview Release #713

Merging dev to master for 6.5.3-preview Release #713

cheenamalhotra commented Jun 1, 2018

codecov-io commented Jun 1, 2018 •

edited

Loading

Merging dev to master for 6.5.3-preview Release #713

Merging dev to master for 6.5.3-preview Release #713

Conversation

cheenamalhotra commented Jun 1, 2018

codecov-io commented Jun 1, 2018 • edited Loading

Codecov Report

codecov-io commented Jun 1, 2018 •

edited

Loading