Spatial datatypes #642

peterbae · 2018-03-05T20:24:29Z

All tests passed.

…atial_Datatypes

Spatial datatypes

codecov-io · 2018-03-05T21:31:12Z

Codecov Report

Merging #642 into dev will increase coverage by 1.71%.
The diff coverage is 83.14%.

@@             Coverage Diff              @@
##                dev     #642      +/-   ##
============================================
+ Coverage     46.45%   48.17%   +1.71%     
- Complexity     2228     2581     +353     
============================================
  Files           109      113       +4     
  Lines         25449    26574    +1125     
  Branches       4193     4429     +236     
============================================
+ Hits          11822    12801     +979     
- Misses        11588    11649      +61     
- Partials       2039     2124      +85

Flag	Coverage Δ	Complexity Δ
#JDBC42	`48.07% <83.14%> (+1.67%)`	`2573 <342> (+347)`	⬆️
#JDBC43	`48.11% <83.14%> (+1.74%)`	`2581 <342> (+357)`	⬆️

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/microsoft/sql/Types.java	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java	`62.76% <100%> (+0.52%)`	`63 <0> (ø)`	⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java	`46.08% <100%> (+1.16%)`	`108 <0> (+4)`	⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java	`63.41% <100%> (+0.75%)`	`0 <0> (ø)`	⬇️
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java	`78.01% <100%> (+0.22%)`	`5 <0> (ø)`	⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java	`33.49% <50%> (+0.61%)`	`249 <2> (+7)`	⬆️
...n/java/com/microsoft/sqlserver/jdbc/Geography.java	`69.53% <69.53%> (ø)`	`33 <33> (?)`
...in/java/com/microsoft/sqlserver/jdbc/Geometry.java	`71.09% <71.09%> (ø)`	`33 <33> (?)`
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java	`50.85% <83.33%> (+0.31%)`	`157 <2> (+2)`	⬆️
...osoft/sqlserver/jdbc/SQLServerSpatialDatatype.java	`87.43% <87.43%> (ø)`	`266 <266> (?)`
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b3c94...66d3da9. Read the comment docs.

cheenamalhotra · 2018-03-06T20:08:12Z

src/test/java/com/microsoft/sqlserver/jdbc/datatypes/SQLServerSpatialDatatypeTest.java

+
+            byte[] geomWKB = Hex.decodeHex("0A00000002001700000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000F03F00000000000008400000000000000840000000000000144000000000000010400000000000001C400000000000001C400000000000000840000000000000F03F00000000000008400000000000000000C7D79E59127037C00000000000000000C7D79E591270374000000000008046C0C7D79E59127037C00000000000000000C7D79E59127037C00000000000000000C7D79E59127037C00000000000001C400000000000001C400000000000000000C7D79E5912703740000000000000204000000000000020400000000000002040000000000000204000000000008046C0C7D79E591270374000000000008056C0C7D79E591270374000000000008056C0C7D79E59127037C000000000008046C0C7D79E59127037C00000000000000000C7D79E59127037C004000000010000000002040000000309000000030D00000001000000FFFFFFFF000000000A080000000203020003010203".toCharArray());
+            byte[] geogWKB = Hex.decodeHex("E6100000020017000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000840000000000000F03F000000000000144000000000000008400000000000001C40000000000000104000000000000008400000000000001C400000000000000840000000000000F03FC7D79E59127037C00000000000000000C7D79E59127037400000000000000000C7D79E59127037C000000000008046C0C7D79E59127037C00000000000000000C7D79E59127037C000000000000000000000000000001C400000000000001C40C7D79E591270374000000000000000000000000000002040000000000000204000000000000020400000000000002040C7D79E591270374000000000008046C0C7D79E591270374000000000008056C0C7D79E59127037C000000000008056C0C7D79E59127037C000000000008046C0C7D79E59127037C0000000000000000004000000010000000002040000000309000000030D00000001000000FFFFFFFF000000000A080000000203020003010203".toCharArray());
+


No need to hard-code and compare byte arrays for all above tests.. please modify tests to compare with database stored values instead.

Discarding change as coverage found in WKT tests

cheenamalhotra · 2018-03-06T20:36:52Z

src/main/java/com/microsoft/sqlserver/jdbc/Geometry.java

+        interpretSerializationPropBytes();
+
+        readNumberOfPoints();
+


Please remove unwanted spaces

…l-jdbc into Spatial_Datatypes

peterbae and others added 15 commits September 27, 2017 14:23

creating files

0e85b0a

stash

6f9a03e

Spatial datatypes parse changes

7972b9d

Parse logic to WKT completed - draft

513c04d

Serialization implementation

3abc116

more serialization logic

40fe6ee

Mostly finished with implementation of spatial datatypes

1583949

Handle Empty cases and added sanity testing for spatial datatypes

07d0a9f

Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into Sp…

5d2bf99

…atial_Datatypes

more testing

a747361

javadoc updates

4ae99af

Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into Sp…

07f06f6

…atial_Datatypes

test changes to make it compatible with sql server 2008

bc1e531

more test changes

ec553a0

Merge pull request #638 from peterbae/Spatial_Datatypes

72cc06d

Spatial datatypes

peterbae requested a review from cheenamalhotra March 5, 2018 20:29

Merge branch 'dev' into Spatial_Datatypes

c264e2a

cheenamalhotra reviewed Mar 6, 2018

View reviewed changes

rene-ye added this to the 6.5.0 milestone Mar 6, 2018

peterbae added 5 commits March 6, 2018 14:39

style changes

b32369f

Merge branch 'dev' into Spatial_Datatypes

d8e6ed9

spacing change

85e3d86

Merge branch 'Spatial_Datatypes' of https://github.com/Microsoft/mssq…

a3975a0

…l-jdbc into Spatial_Datatypes

spacing changes

e7bfc3b

cheenamalhotra approved these changes Mar 7, 2018

View reviewed changes

Merge branch 'dev' into Spatial_Datatypes

66d3da9

rene-ye self-requested a review March 8, 2018 19:05

rene-ye approved these changes Mar 8, 2018

View reviewed changes

peterbae merged commit 957da5d into dev Mar 8, 2018

cheenamalhotra deleted the Spatial_Datatypes branch October 1, 2018 18:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spatial datatypes #642

Spatial datatypes #642

peterbae commented Mar 5, 2018 •

edited

Loading

codecov-io commented Mar 5, 2018 •

edited

Loading

cheenamalhotra Mar 6, 2018

cheenamalhotra Mar 7, 2018

cheenamalhotra Mar 6, 2018


		byte[] geomWKB = Hex.decodeHex("0A00000002001700000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000F03F00000000000008400000000000000840000000000000144000000000000010400000000000001C400000000000001C400000000000000840000000000000F03F00000000000008400000000000000000C7D79E59127037C00000000000000000C7D79E591270374000000000008046C0C7D79E59127037C00000000000000000C7D79E59127037C00000000000000000C7D79E59127037C00000000000001C400000000000001C400000000000000000C7D79E5912703740000000000000204000000000000020400000000000002040000000000000204000000000008046C0C7D79E591270374000000000008056C0C7D79E591270374000000000008056C0C7D79E59127037C000000000008046C0C7D79E59127037C00000000000000000C7D79E59127037C004000000010000000002040000000309000000030D00000001000000FFFFFFFF000000000A080000000203020003010203".toCharArray());
		byte[] geogWKB = Hex.decodeHex("E6100000020017000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000840000000000000F03F000000000000144000000000000008400000000000001C40000000000000104000000000000008400000000000001C400000000000000840000000000000F03FC7D79E59127037C00000000000000000C7D79E59127037400000000000000000C7D79E59127037C000000000008046C0C7D79E59127037C00000000000000000C7D79E59127037C000000000000000000000000000001C400000000000001C40C7D79E591270374000000000000000000000000000002040000000000000204000000000000020400000000000002040C7D79E591270374000000000008046C0C7D79E591270374000000000008056C0C7D79E59127037C000000000008056C0C7D79E59127037C000000000008046C0C7D79E59127037C0000000000000000004000000010000000002040000000309000000030D00000001000000FFFFFFFF000000000A080000000203020003010203".toCharArray());

Spatial datatypes #642

Spatial datatypes #642

Conversation

peterbae commented Mar 5, 2018 • edited Loading

codecov-io commented Mar 5, 2018 • edited Loading

Codecov Report

cheenamalhotra Mar 6, 2018

Choose a reason for hiding this comment

cheenamalhotra Mar 7, 2018

Choose a reason for hiding this comment

cheenamalhotra Mar 6, 2018

Choose a reason for hiding this comment

peterbae commented Mar 5, 2018 •

edited

Loading

codecov-io commented Mar 5, 2018 •

edited

Loading