Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSAL and Azure Identity version bump #2433

Merged
merged 1 commit into from
May 24, 2024
Merged

MSAL and Azure Identity version bump #2433

merged 1 commit into from
May 24, 2024

Conversation

tkyc
Copy link
Member

@tkyc tkyc commented May 24, 2024

Bumped MSAL to 1.15.0 and bumped azure-identity to 1.12.1.

@tkyc
Copy link
Member Author

tkyc commented May 24, 2024

Version bump broke driver logic in SQLServerMSAL4JUtils.getSqlFedAuthTokenInteractive with error below.

Exception in thread "main" java.lang.NoSuchMethodError: 'com.microsoft.aad.msal4j.AbstractClientApplicationBase$Builder com.microsoft.aad.msal4j.PublicClientApplication$Builder.executorService(java.util.concurrent.ExecutorService)'

        at com.microsoft.sqlserver.jdbc.SQLServerMSAL4JUtils.getSqlFedAuthTokenInteractive(SQLServerMSAL4JUtils.java:357)

        at com.microsoft.sqlserver.jdbc.SQLServerConnection.getFedAuthToken(SQLServerConnection.java:6170)

        at com.microsoft.sqlserver.jdbc.SQLServerConnection.onFedAuthInfo(SQLServerConnection.java:6001)

        at com.microsoft.sqlserver.jdbc.SQLServerConnection.processFedAuthInfo(SQLServerConnection.java:5835)

        at com.microsoft.sqlserver.jdbc.TDSTokenHandler.onFedAuthInfo(tdsparser.java:346)

        at com.microsoft.sqlserver.jdbc.TDSParser.parse(tdsparser.java:130)

        at com.microsoft.sqlserver.jdbc.TDSParser.parse(tdsparser.java:42)

        at com.microsoft.sqlserver.jdbc.SQLServerConnection.sendLogon(SQLServerConnection.java:6894)

        at com.microsoft.sqlserver.jdbc.SQLServerConnection.logon(SQLServerConnection.java:5440)

        at com.microsoft.sqlserver.jdbc.SQLServerConnection$LogonCommand.doExecute(SQLServerConnection.java:5372)

        at com.microsoft.sqlserver.jdbc.TDSCommand.execute(IOBuffer.java:7775)

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.06%. Comparing base (9d503dd) to head (046eefb).

Current head 046eefb differs from pull request most recent head 2b8a977

Please upload reports for the commit 2b8a977 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2433      +/-   ##
============================================
- Coverage     50.12%   50.06%   -0.06%     
+ Complexity     3834     3831       -3     
============================================
  Files           145      145              
  Lines         33394    33394              
  Branches       5662     5662              
============================================
- Hits          16738    16720      -18     
- Misses        14254    14276      +22     
+ Partials       2402     2398       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkyc tkyc merged commit c79befa into main May 24, 2024
17 checks passed
@tkyc tkyc deleted the msal-azure-identity-bump branch May 24, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

3 participants