Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection.getMetaData().getProcedures(String,String,String)) missing 9th column #1491

Conversation

garydgregory
Copy link

Connection.getMetaData().getProcedures(String,String,String)) should return 9 columns but is missing the 9th column SPECIFIC_NAME.

While the underlying server's stored procedure only returns 8 columns, the JDBC API must return the 9th to be compliant with the API even if the column values are null. This bug makes is harder to write JDBC code that is vendor neutral.

If you agree this is a bug, I can provide a fix.

@garydgregory garydgregory force-pushed the dbmetadata_GetProceduresResultSetMetaData_col9_missing branch from 73e98dd to 9150e70 Compare December 23, 2020 14:23
@peterbae
Copy link
Contributor

peterbae commented Jan 4, 2021

Hi @garydgregory, that sounds like a good fix. If you could add the changes to this PR, the team will review it.

@garydgregory garydgregory force-pushed the dbmetadata_GetProceduresResultSetMetaData_col9_missing branch from 9150e70 to e1b6c5a Compare January 6, 2021 00:49
return 9 columns but is missing the 9th column called SPECIFIC_NAME.

The issues is that the underlying server sp_stored_procedures() returns
8 columns while the API expects 9 columns. The driver passes the result
set as is to the caller.

This patch allows the JDBC getProcedures() API to add the missing
column.
@garydgregory garydgregory force-pushed the dbmetadata_GetProceduresResultSetMetaData_col9_missing branch from e1b6c5a to 4045815 Compare January 6, 2021 00:51
@garydgregory garydgregory changed the title Connection.getMetaData().getProcedures(String,String,String)) missing column Connection.getMetaData().getProcedures(String,String,String)) missing 9th column Jan 6, 2021
@lilgreenbird lilgreenbird added the Enhancement An enhancement to the driver. Lower priority than bugs. label Nov 30, 2021
@Jeffery-Wasty Jeffery-Wasty self-assigned this Sep 26, 2023
@Jeffery-Wasty Jeffery-Wasty removed their assignment Oct 11, 2023
@barryw-mssql
Copy link
Contributor

We have looked at this PR and have found that it does not work with the existing code base. We want to get this working but at this point we have not been able to dedicate the effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement An enhancement to the driver. Lower priority than bugs.
Projects
Status: Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

5 participants