Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Misleading error message in CallableStatement #1064

Merged
merged 19 commits into from
Jun 10, 2019

Conversation

rene-ye
Copy link
Member

@rene-ye rene-ye commented May 22, 2019

Fixed an issue where CallableStatement was not setting parameter indexes properly when columns aren't found via column name lookup. This results in the driver returning a misleading error message early instead of executing the statement and receiving the proper message from server. Addresses issue #1059.

@cheenamalhotra cheenamalhotra added this to the 7.3.1 milestone May 22, 2019
@codecov-io
Copy link

codecov-io commented May 23, 2019

Codecov Report

Merging #1064 into dev will increase coverage by 0.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1064      +/-   ##
============================================
+ Coverage     53.08%   53.12%   +0.04%     
- Complexity     3159     3172      +13     
============================================
  Files           119      119              
  Lines         28022    28121      +99     
  Branches       4688     4694       +6     
============================================
+ Hits          14875    14940      +65     
- Misses        10912    10949      +37     
+ Partials       2235     2232       -3
Impacted Files Coverage Δ Complexity Δ
...oft/sqlserver/jdbc/SQLServerCallableStatement.java 29.6% <33.33%> (+0.08%) 100 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 45.05% <0%> (-2.2%) 15% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.51% <0%> (-0.87%) 112% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 60.83% <0%> (-0.67%) 0% <0%> (ø)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 49.55% <0%> (-0.07%) 393% <0%> (-2%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 51.56% <0%> (-0.07%) 255% <0%> (-1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39.22% <0%> (+0.21%) 44% <0%> (+1%) ⬆️
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 80.3% <0%> (+0.22%) 6% <0%> (ø) ⬇️
...rosoft/sqlserver/jdbc/InternalSpatialDatatype.java 91.66% <0%> (+0.36%) 6% <0%> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 60.94% <0%> (+1.18%) 35% <0%> (+1%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91c7ea...1e57d55. Read the comment docs.

@rene-ye rene-ye requested a review from lilgreenbird June 3, 2019 16:45
cheenamalhotra
cheenamalhotra previously approved these changes Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants