-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix | Misleading error message in CallableStatement #1064
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1064 +/- ##
============================================
+ Coverage 53.08% 53.12% +0.04%
- Complexity 3159 3172 +13
============================================
Files 119 119
Lines 28022 28121 +99
Branches 4688 4694 +6
============================================
+ Hits 14875 14940 +65
- Misses 10912 10949 +37
+ Partials 2235 2232 -3
Continue to review full report at Codecov.
|
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerCallableStatement.java
Show resolved
Hide resolved
peterbae
reviewed
May 23, 2019
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerCallableStatement.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java
Show resolved
Hide resolved
…allableMixedTest.java Co-Authored-By: Cheena Malhotra <[email protected]>
…allableMixedTest.java Co-Authored-By: Cheena Malhotra <[email protected]>
…allableMixedTest.java Co-Authored-By: Cheena Malhotra <[email protected]>
…allableMixedTest.java Co-Authored-By: Cheena Malhotra <[email protected]>
…allableMixedTest.java Co-Authored-By: Cheena Malhotra <[email protected]>
…allableMixedTest.java Co-Authored-By: Cheena Malhotra <[email protected]>
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java
Outdated
Show resolved
Hide resolved
cheenamalhotra
previously approved these changes
Jun 5, 2019
lilgreenbird
reviewed
Jun 5, 2019
ulvii
reviewed
Jun 9, 2019
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java
Show resolved
Hide resolved
ulvii
reviewed
Jun 9, 2019
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java
Show resolved
Hide resolved
ulvii
reviewed
Jun 9, 2019
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerCallableStatement.java
Show resolved
Hide resolved
ulvii
approved these changes
Jun 10, 2019
cheenamalhotra
approved these changes
Jun 10, 2019
lilgreenbird
approved these changes
Jun 10, 2019
peterbae
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where CallableStatement was not setting parameter indexes properly when columns aren't found via column name lookup. This results in the driver returning a misleading error message early instead of executing the statement and receiving the proper message from server. Addresses issue #1059.