-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify datapath #3819
Unify datapath #3819
Conversation
… DATAPATH{RAW*, BASE{callbacks}}
if ($UseXdp) { | ||
# Helper for XDP usage | ||
if ($ForBuild) { | ||
$InstallXdpSdk = $true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why skipping installing XdpSdk for build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ($ForBuild) {
below already has $InstallXdpSdk = $true
.
Not sure it's related to this PR or not, but it seems stress hit a crash:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If all the tests pass, let's get this merged. Thanks Daiki for all the hard work!
Thanks for review!! |
Description
Unifying windows normal socket and raw (xdp) socket
Testing
adjusting tests
Documentation
Architecture.md and TEST.md