-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shutdown Stream on Send/Start Failure #3637
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csujedihy
reviewed
May 17, 2023
csujedihy
previously approved these changes
May 17, 2023
there's a build error. Finding the error in the github action is like finding a needle in a haystack. The console coloring is all gone.
|
Feel free to push a fix, otherwise I will tomorrow. |
pongba
reviewed
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May need to add 3 unit test cases to cover the following:
- If StreamSend returns SUCCESS,
SEND_COMPLETE
must be indicated exactly-once - If StreamSend returns FAIL,
SEND_COMPLETE
must not be indicated. - If StreamSend(
QUIC_SEND_FLAG_START
) returns SUCCESS,STREAM_SHUTDOWN_COMPLETE
must be indicated exactly-once.
csujedihy
approved these changes
May 18, 2023
4 tasks
nibanks
added a commit
that referenced
this pull request
May 19, 2023
nibanks
added a commit
that referenced
this pull request
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3638 and #3639. In the rare case (OOM) that stream start fails when you use the
QUIC_SEND_FLAG_START
flag, it should be delivering a shutdown complete event to indicate this failure to start. Also fixes more event issues in the case of OOM in the send flush operation alloc path.Testing
Existing automation and manual testing from original bug opener.
Documentation
N/A