Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip SW encryption on Tx path when QEO enabled #3630

Merged
merged 1 commit into from
May 15, 2023

Conversation

ami-GS
Copy link
Contributor

@ami-GS ami-GS commented May 15, 2023

Description

Skip SW encryption on TX path when QEO enabled

Testing

No actual feature yet

Documentation

N/A

@ami-GS ami-GS requested a review from a team as a code owner May 15, 2023 16:57
@ami-GS
Copy link
Contributor Author

ami-GS commented May 15, 2023

CxPlatEncrypt is called not only from packet_builder.c:QuicPacketBuilderFinalize, but also from binding.c:QuicBindingProcessStatelessOperation and packet.c:QuicPacketGenerateRetryIntegrity. However not sure these are for payload of short header

@nibanks
Copy link
Member

nibanks commented May 15, 2023

CxPlatEncrypt is called not only from packet_builder.c:QuicPacketBuilderFinalize, but also from binding.c:QuicBindingProcessStatelessOperation and packet.c:QuicPacketGenerateRetryIntegrity. However not sure these are for payload of short header

QEO won't apply to stateless operations and retry packets, so you can safely ignore those.

@ami-GS
Copy link
Contributor Author

ami-GS commented May 15, 2023

Thanks!

@ami-GS ami-GS enabled auto-merge (squash) May 15, 2023 17:05
@ami-GS ami-GS merged commit b6a8525 into main May 15, 2023
@ami-GS ami-GS deleted the dev/daiki/qeo_skip_tx_sw_encryption branch May 15, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants