This repository has been archived by the owner on Nov 5, 2021. It is now read-only.
Remove another require call #49
Merged
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 26, 2019
|
Great! Thank you! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
import-typescriptscript to remove a newrequirecall fromtypescriptServices.js, which was breaking webpack builds (see microsoft/monaco-editor#1623 - though they were incorrect about it being a plugin issue).To prevent similar issues from reaching users in the future, I added logic in the import script to look for additional (uncommented)
requirecalls and report an error if it finds one. That way the break can be detected and fixed at the time the TS version is being bumped.