Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused browser argument when creating WebView2 CompositionController #7530

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

krschau
Copy link
Contributor

@krschau krschau commented Jul 25, 2022

The msEmbeddedBrowserVisualHosting browser argument is no longer used by Edge, and instead we opt into visual hosting by calling CreateCoreWebView2CompositionControllerAsync(). This change just removes the unused flag and environment option property.

@krschau krschau requested a review from DmitriyKomin July 25, 2022 22:05
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jul 25, 2022
@krschau
Copy link
Contributor Author

krschau commented Jul 25, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@DmitriyKomin DmitriyKomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@krschau krschau added area-WebView and removed needs-triage Issue needs to be triaged by the area owners labels Aug 2, 2022
@krschau krschau merged commit 9670f76 into main Aug 2, 2022
@krschau krschau deleted the user/krschau/rem-addl-browser-args branch August 2, 2022 16:46
@ghost
Copy link

ghost commented Aug 15, 2022

🎉Microsoft.UI.Xaml v2.8.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants