Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NavigationViewTemplateSettings.OpenPaneLength Update #7341

Merged
merged 2 commits into from
Jul 10, 2022
Merged

NavigationViewTemplateSettings.OpenPaneLength Update #7341

merged 2 commits into from
Jul 10, 2022

Conversation

karkarl
Copy link
Contributor

@karkarl karkarl commented Jul 7, 2022 •
edited by ranjeshj
Loading

Description

  • Update NavigationViewTemplateSettings.OpenPaneWidth to NavigationViewTemplateSettings.OpenPaneLength.
  • Update API to public_V2

Motivation and Context

Fixes #6682

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jul 7, 2022
@ojhad ojhad added area-NavigationView NavView control team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jul 7, 2022
@ranjeshj ranjeshj requested review from kmahone and MikeHillberg July 7, 2022 23:51
@ranjeshj
Copy link
Contributor

ranjeshj commented Jul 7, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kmahone
kmahone approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@kmahone kmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ranjeshj ranjeshj merged commit bace2c5 into main Jul 10, 2022
@ranjeshj ranjeshj deleted the user/karenlai/NavViewTemplateSettingsUpdate branch July 10, 2022 13:17
MartinZikmund added a commit to unoplatform/uno that referenced this pull request Sep 5, 2023
@MartinZikmund
feat(NavigationView): Include NavigationViewTemplateSettings.OpenPane…
d961e8f 
…Length Update

microsoft/microsoft-ui-xaml#7341
MartinZikmund added a commit to unoplatform/uno that referenced this pull request Sep 18, 2023
@MartinZikmund
feat(NavigationView): Include NavigationViewTemplateSettings.OpenPane…
4db764c 
…Length Update

microsoft/microsoft-ui-xaml#7341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmahone kmahone kmahone approved these changes

@ranjeshj ranjeshj ranjeshj approved these changes

@MikeHillberg MikeHillberg Awaiting requested review from MikeHillberg

Assignees
No one assigned
Labels
area-NavigationView NavView control team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NavigationViewTemplateSettings is missing OpenPaneWidth
4 participants
@karkarl @ranjeshj @kmahone @ojhad