Fixed Corner Radius Issue with InkToolbar Custom Tool Button #6724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| Height="{StaticResource InkToolbarButtonHeight}"> | ||
|
|
||
| Height="{StaticResource InkToolbarButtonHeight}" | ||
| contract7Present:CornerRadius="{TemplateBinding CornerRadius}" > |
There was a problem hiding this comment.
Thanks for the fix! could you please also add
contract7NotPresent:CornerRadius="{ThemeResource ControlCornerRadius}"
like you can see here:
so that this works downlevel as well?There was a problem hiding this comment.
Hey Stephen, I did not add 'contract7NotPresent' because I did not find it on any other style/template in the file InkToolbar_themeresources.xaml. If it has to be added then I think we should add this to other styles/templates in this file as well.
There was a problem hiding this comment.
I see, I think that is an oversight, however we can save it for a later update.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
approved these changes
Feb 28, 2022
StephenLPeters
added
team-Controls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corner Radius property was missing on the InkToolbarCustomToolButton Style. I have just added a Corner Radius property on the Root Grid of the button. It was already available for other buttons in toolbar but not for CustomToolButton.
Motivation and Context
It was was causing the Custom Tool Buttons to have sharp corner and was not aligning with the rest of the buttons.
Partially fixes Ticket 5844
How Has This Been Tested?
Tested in local environment. Screenshot attached.
Screenshots (if appropriate):