Update ScrollBar thumb template to use ThemeResource instead of StaticResource #6686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
reviewed
Feb 9, 2022
| @@ -743,7 +743,7 @@ | |||
| Background="{ThemeResource ScrollBarPanningThumbBackground}" | |||
| BorderBrush="{ThemeResource ScrollBarThumbBorderBrush}" | |||
| Template="{StaticResource HorizontalThumbTemplate}" | |||
| Height="{StaticResource ScrollBarHorizontalThumbMinHeight}" | |||
| Height="{ThemeResource ScrollBarHorizontalThumbMinHeight}" | |||
| MinWidth="{StaticResource ScrollBarHorizontalThumbMinWidth}" | |||
There was a problem hiding this comment.
How about changing this to ThemeResource as well?
| @@ -782,7 +782,7 @@ | |||
| Background="{ThemeResource ScrollBarPanningThumbBackground}" | |||
| BorderBrush="{ThemeResource ScrollBarThumbBorderBrush}" | |||
| Template="{StaticResource VerticalThumbTemplate}" | |||
| Width="{StaticResource ScrollBarVerticalThumbMinWidth}" | |||
| Width="{ThemeResource ScrollBarVerticalThumbMinWidth}" | |||
| MinHeight="{StaticResource ScrollBarVerticalThumbMinHeight}" | |||
There was a problem hiding this comment.
How about changing this to ThemeResource as well?
StephenLPeters
added
area-Resources
area-ScrollBar
team-Controls
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bpulliam
approved these changes
Dec 2, 2022
bpulliam
force-pushed
the
user/stpete/EnableThumbResourcesOverrides
branch
from
ada0838 to
77a603b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
microsoft-github-policy-service
bot
added
the
needs-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Resource isn't overrideable in its current state and this change allows terminal to change the width of their scrollbars microsoft/terminal#9218