Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental TitleBar] Collapse TitleText when empty #6326

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

SamChaps
Copy link
Contributor

Description

When the TitleBar TitleText is empty make sure to collapse the TitleText Textblock so that it does not take any extra space.

  • Add title property changed handler
  • Add visual states for title visibility
  • Apply visual state change if the title is empty or not

Motivation and Context

Allows TitleBar consumers to have responsive UI and remove the extra space that an empty title was adding.

How Has This Been Tested?

Tested via the MUXExpirementalTestApp.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Nov 17, 2021
dev/TitleBar/TitleBar.cpp Outdated Show resolved Hide resolved
dev/TitleBar/TitleBar.cpp Outdated Show resolved Hide resolved
@SamChaps SamChaps requested a review from teaP November 17, 2021 18:33
Copy link
Contributor

@teaP teaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@teaP
Copy link
Contributor

teaP commented Nov 17, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@teaP teaP merged commit fc02d50 into microsoft:main Nov 17, 2021
@StephenLPeters StephenLPeters added area-TitleBar Issues related to custom window title bars. team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TitleBar Issues related to custom window title bars. team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants