Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ContentDialog] Update background smoke for HC #6266

Merged
merged 4 commits into from
Nov 10, 2021
Merged

Conversation

tashatitova
Copy link
Contributor

Based on user feedback, some smoke is preferred in HC scenarios as well.

Before and after, aqua:
aqua-before
aqua-updated]

Before and after, desert:
desert-before

desert-updated

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Nov 9, 2021
@tashatitova
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -14,40 +14,55 @@
<StaticResource x:Key="CalendarDatePickerForeground" ResourceKey="TextFillColorPrimaryBrush" />
<StaticResource x:Key="CalendarDatePickerForegroundDisabled" ResourceKey="TextFillColorDisabledBrush" />
<StaticResource x:Key="CalendarDatePickerCalendarGlyphForeground" ResourceKey="TextFillColorSecondaryBrush" />
<StaticResource x:Key="CalendarDatePickerCalendarGlyphForegroundPointerOver" ResourceKey="TextFillColorSecondaryBrush" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Picker updates are unrelated. Can you undo the changes not related to content dialog ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, updated. thanks!

@tashatitova
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tashatitova tashatitova merged commit aae7559 into main Nov 10, 2021
@tashatitova tashatitova deleted the user/tatito/dialog branch November 10, 2021 17:31
@StephenLPeters StephenLPeters added area-Dialogs team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Dialogs team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants