You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NavView was crashing whenever IsPaneVisible property is set to false. This is due to SplitView.CompactPaneLength() returning 0 when not visible, resulting in a negative value for TemplateSettings.SmallerIconWidth.
A check is now added to ensure the minimum value is 0.
@karenbtlai Did the tests repro the issue for you? I ran them without the fix and the app did not crash nor did the tests fail 🤔
Huh, weirdly enough, the app does not crash when I'm manually testing it with the deployed appx in the BuildOutput (which is what the interaction tests consume), but repros / crashes without the fix when running using VS? @StephenLPeters any idea what's happening here?
@karenbtlai Did the tests repro the issue for you? I ran them without the fix and the app did not crash nor did the tests fail 🤔
Huh, weirdly enough, the app does not crash when I'm manually testing it with the deployed appx in the BuildOutput (which is what the interaction tests consume), but repros / crashes without the fix when running using VS? @StephenLPeters any idea what's happening here?
Is it an exception that is thrown but caught ? If you see it only in the debugger then that's likely the issue.
@ranjeshj thanks for setting the milestone but is there any chance of getting a prerelease with this update to unblock us. Unfortunately setting DISABLE_XAML_GENERATED_BREAK_ON_UNHANDLED_EXCEPTION with was the suggested workaround doesn't work
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
added
the
ranjeshj
added
area-NavigationView
Description
NavView was crashing whenever
IsPaneVisibleproperty is set to false. This is due toSplitView.CompactPaneLength()returning 0 when not visible, resulting in a negative value forTemplateSettings.SmallerIconWidth.Motivation and Context
Fixes #5971
How Has This Been Tested?
Tests previously covering this scenario is now re-enabled to prevent regression.