Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and push Microsoft.UI.Xaml vpack as part of Release Build #6131

Merged
merged 5 commits into from
Oct 20, 2021

Conversation

kmahone
Copy link
Member

@kmahone kmahone commented Oct 20, 2021

To have Microsoft.UI.Xaml framework package preinstalled in the OS, we need to create and push a vpack containing the appx so that it can be consumed by the OS.

This was previously done by manually creating and pushing the vpack on an individual's machine, but we need to move this to happen as part of the Pipeline run.

In order for this to happen we need to replace the manual step of Store-signing the framework package with a task in the Pipeline. This PR adds that which simplifies the release process.

We also create and push the Microsoft.UI.Xaml vpack from the Pipeline. This is in addition to the existing CBS vpacks that we also push. The Microsoft.UI.Xaml vpack contains the same framework package as what gets published to the store.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Oct 20, 2021
@kmahone kmahone requested review from jevansaks and ranjeshj October 20, 2021 19:05
@kmahone
Copy link
Member Author

kmahone commented Oct 20, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

$destPathFull = Join-Path $targetFolder $fileName

Write-Verbose "Copy item from '$sourcePathFull' to '$destPathFull' "
Copy-Item $sourcePathFull $destPathFull
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is putting it all in the same vpack as the ones that go into the CBS framework package? Currently we're sourcing those from different commits so would it be better to have these be two separate vpacks just to make it clear that they're ok to manage independently?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a separate vpack. The Pipeline run will create both the "standard" WinUI Vpack and the CBS vpacks. There are 6 vpacks produced in total:

  • Microsoft.UI.Xaml (contains the public framework package .appx)

The CBS Vpacks:

  • MicrosoftUIXamlInbox_x64 (contains the contents of the CBS package - no appx)
  • MicrosoftUIXamlInbox_x86
  • MicrosoftUIXamlInbox_arm
  • MicrosoftUIXamlInbox_arm64
  • MicrosoftUIXamlInboxWinmd (the winmd for the CBS package)

Does that make sense?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok great. I see that now. The script populates the directories but then we have another task to push them. Got it.

$destPathFull = Join-Path $targetFolder $fileName

Write-Verbose "Copy item from '$sourcePathFull' to '$destPathFull' "
Copy-Item $sourcePathFull $destPathFull
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok great. I see that now. The script populates the directories but then we have another task to push them. Got it.

@kmahone kmahone merged commit 51cf944 into main Oct 20, 2021
@kmahone kmahone deleted the user/kmahone/winuivpack branch October 20, 2021 21:57
@StephenLPeters StephenLPeters added area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency area-NugetPackage Issue with the nuget package developer experience (e.g. build error, missing files) team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Oct 21, 2021
StephenLPeters pushed a commit that referenced this pull request Oct 21, 2021
* Publish symbols to symweb (#6014)

* Fix CBS Vpack to handle WebView2 (#6033)

* Update TeachingTip and SwipeControl to use XamlRootChanged_revoker (#6121)

* Create and push Microsoft.UI.Xaml vpack as part of Release Build (#6131)
@ghost
Copy link

ghost commented Jul 13, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220712001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 18, 2022

🎉Microsoft.UI.Xaml v2.8.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 3, 2023

🎉Microsoft.UI.Xaml v2.8.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency area-NugetPackage Issue with the nuget package developer experience (e.g. build error, missing files) team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants