Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Duplicate resources for TopNavigationViewItem style brushes #5910

Merged
merged 3 commits into from
Sep 28, 2021
Merged

Removed Duplicate resources for TopNavigationViewItem style brushes #5910

merged 3 commits into from
Sep 28, 2021

Conversation

aqibbanday
Copy link
Contributor

@aqibbanday aqibbanday commented Sep 18, 2021 •
edited
Loading

Description

I have removed the duplicate resources as mentioned in the following issue
#5869

Motivation and Context

Removed duplicate resources present in \dev\NavigationView\NavigationView_rs1_themeresources.xaml
#5869
"Closes #5869"

How Has This Been Tested?

Tested by running the MUXControlsTestApp>NavigationView>Top Mode Tests
No Change in behavior detected.

Screenshots (if appropriate):

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Sep 18, 2021
@aqibbanday aqibbanday mentioned this pull request Sep 18, 2021
Closed
@ranjeshj
Copy link
Contributor

@aqibbanday There are lots of change in this PR which seem to be unrelated to the issue we are trying to fix here. Can you remove the unrelated changes ?

@aqibbanday
Copy link
Contributor Author

@aqibbanday There are lots of change in this PR which seem to be unrelated to the issue we are trying to fix here. Can you remove the unrelated changes ?

Its seems, XAML styler has added indentation to few XAML files. No breaking change.
I can remove it if required.

@aqibbanday
Copy link
Contributor Author

@ranjeshj Hi, I have reverted extra changes made, this is the final commit: 6646016

@StephenLPeters StephenLPeters added area-NavigationView NavView control team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Sep 21, 2021
@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj merged commit af57e7f into microsoft:main Sep 28, 2021
@ghost
Copy link

ghost commented Apr 14, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220413001 has been released which incorporates this pull request.:tada:

Handy links:

This was referenced Apr 14, 2022
Closed
Merged
@ghost
Copy link

ghost commented Jul 13, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220712001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 18, 2022

🎉Microsoft.UI.Xaml v2.8.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 3, 2023

🎉Microsoft.UI.Xaml v2.8.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranjeshj ranjeshj ranjeshj approved these changes

@StephenLPeters StephenLPeters StephenLPeters approved these changes

Assignees
No one assigned
Labels
area-NavigationView NavView control team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate resources for TopNavigationViewItem style brushes
3 participants
@aqibbanday @ranjeshj @StephenLPeters