Fix issue with NavigationViewItem announcing collapsed when not having children #2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
StephenLPeters
added
accessibility
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Jul 3, 2020
ranjeshj
added
the
needs-cherrypicktorelease
ranjeshj
pushed a commit
that referenced
this pull request
Jul 7, 2020
…g children (#2770) * Fix issue with collapse being announced on NavViewItem with no children * Add test
ranjeshj
removed
the
needs-cherrypicktorelease
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a check to the NavigationViewItemAutomationPeer whether the NavViewItem it represents has children or not. If the item has no children, we don't return that as the automation peer for the ExpandCollapse pattern.
Motivation and Context
Closes #2598
How Has This Been Tested?
Added new API test, tested manually with narrator
Screenshots (if appropriate):