Fix to sizing issue when TabView is aligned left. #1744
Merged
+132
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
|
Can we add automated test coverage for this scenario to prevent regressions? |
|
Approved but should probably have a test as Keith mentioned. |
jevansaks
added
area-TabView
needs-cherrypicktorelease
5 tasks
jevansaks
pushed a commit
that referenced
this pull request
Dec 11, 2019
Fix to sizing issue when TabView is aligned left. Added test.
jevansaks
removed
the
needs-cherrypicktorelease
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1581. Basically, the TabView would only get smaller, never larger. By updating the tab widths on Measure instead of SizeChanged, we can expand to use available space.