Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Scroller test code for mouse-based panning and mouse-based constant-velocity-panning #1472

Merged
merged 2 commits into from
Oct 22, 2019
Merged

New Scroller test code for mouse-based panning and mouse-based constant-velocity-panning #1472

merged 2 commits into from
Oct 22, 2019

Conversation

RBrid
Copy link
Contributor

@RBrid RBrid commented Oct 21, 2019

Description

Just adding a new Scroller test page to MUXControlsTestApp with prototypes of mouse-based panning and mouse-based constant-velocity-panning.

Motivation and Context

  • New test page can be used as a starting point for supporting mouse-based panning in customer applications, or in future Scroller release.
  • New test page showcases shortcomings of current Xaml framework and Scroller for supporting mouse-based constant-velocity-panning.

How Has This Been Tested?

Tested the new page using MUXControlsTestApp.

@RBrid RBrid requested a review from a team October 21, 2019 20:54
@RBrid RBrid self-assigned this Oct 21, 2019
@RBrid RBrid mentioned this pull request Oct 21, 2019
Open
StephenLPeters
StephenLPeters previously approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@StephenLPeters StephenLPeters dismissed their stale review October 22, 2019 16:51

revoking review

@RBrid RBrid requested a review from StephenLPeters October 22, 2019 17:23
StephenLPeters
StephenLPeters approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@RBrid RBrid merged commit f647d63 into master Oct 22, 2019
@RBrid RBrid deleted the user/rbrid/ScrollerMousePanning branch October 22, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenLPeters StephenLPeters StephenLPeters approved these changes

Assignees

@RBrid RBrid

Labels
area-Scrolling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RBrid @StephenLPeters