Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: NavigationView should expose lightweight styling resources to customize the margin of the NavigationViewItem's IconBox in Top pane display mode #2924

Open
Felix-Dev opened this issue Jul 15, 2020 · 4 comments
Assignees
Labels
area-NavigationView NavView control feature proposal New feature proposal team-Controls Issue for the Controls team

Comments

@Felix-Dev
Copy link
Contributor

Felix-Dev commented Jul 15, 2020

Proposal: NavigationView should expose lightweight styling resources to customize the margin of the NavigationViewItem's IconBox in Top pane display mode

Summary

The NavigationView right now only exposes a lightweight-styling resource to set the margin of the NavigationViewItem's IconBox in Left pane display mode:

Margin="{ThemeResource NavigationViewItemOnLeftIconBoxMargin}">

A corresponding resource for the Top pane display mode is currently missing:

This proposal aims to close the gap by introducing two new resources:

  • TopNavigationViewIconBoxMargin
  • TopNavigationViewOnOverflowIconBoxMargin

While the naming scheme differs from the existing resource in Left pane display mode - which is named NavigationViewItemOnLeftIconBoxMargin - that naming scheme used there is inconsistent with the naming scheme used by the vast majority of the other NavigationView theme resources. The prefixes "NavigationView" or "TopNavigationView" are overwhelmingly used to distinguish between specific theme resources for the NavigationView in Left mode and in Top mode, respectively. (Issue #2906 has been created to track the task to provide a consistent lightweight styling experience for the NavigationView.) As such, I suggest we follow the commonly used naming scheme here for these two proposed resources (instead of introducing them using a naming scheme which means they will potentially have to be updated in the future).

@Felix-Dev Felix-Dev added the feature proposal New feature proposal label Jul 15, 2020
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jul 15, 2020
@Felix-Dev Felix-Dev changed the title Proposal: NavigationView should expose theme resources to customize the margin of the NavigationViewItem's IconBox in Top pane display mode Proposal: NavigationView should expose lightweight styling resources to customize the margin of the NavigationViewItem's IconBox in Top pane display mode Jul 15, 2020
@StephenLPeters
Copy link
Contributor

@Felix-Dev can you provide a screenshot highlighting the UI part in question?

@StephenLPeters StephenLPeters added area-NavigationView NavView control team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jul 15, 2020
@Felix-Dev
Copy link
Contributor Author

Felix-Dev commented Jul 15, 2020

@StephenLPeters Sure. The UI with its margin configurable via lightweight styling has been marked in a red background in the pics below:
image
image

Today, the margin can be customized via lightweight-styling in the Left pane display mode. Support for this is currently missing in the Top pane display mode (including the overflow menu).

@mdtauk
Copy link
Contributor

mdtauk commented Jul 15, 2020

This could be important when developing an Xbox control template for the control.

There are special requirements of safe areas and moving content inwards that this could help with

@StephenLPeters
Copy link
Contributor

Thanks, the photos help with the proposal process quite a bit :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NavigationView NavView control feature proposal New feature proposal team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

5 participants