Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align naming for NavView themeresources #2906

Closed
marcelwgn opened this issue Jul 14, 2020 · 2 comments
Closed

Align naming for NavView themeresources #2906

marcelwgn opened this issue Jul 14, 2020 · 2 comments
Labels
area-NavigationView NavView control area-Styling no-issue-activity team-Controls Issue for the Controls team

Comments

@marcelwgn
Copy link
Collaborator

Some resource are following an inconsisten naming scheme e.g. NavigationViewTopPaneHeight and TopNavigationViewItemSeparatorMargin. We should update those to be consistent once we have resource indirection and we can make that change without breaking existent usage.
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jul 14, 2020
@marcelwgn marcelwgn mentioned this issue Jul 14, 2020
Merged
This was referenced Jul 15, 2020
Open
Open
@StephenLPeters
Copy link
Contributor

We need to be very careful to not make breaking changes in this space.

@StephenLPeters StephenLPeters added area-Styling team-Controls Issue for the Controls team area-NavigationView NavView control and removed needs-triage Issue needs to be triaged by the area owners labels Jul 15, 2020
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-NavigationView NavView control area-Styling no-issue-activity team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@StephenLPeters @marcelwgn @msft-github-bot