Add ability to run multiple processing strategies #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
akarys92
changed the title
davisjms
suggested changes
Aug 8, 2018
| Logger.InfoFormat("Initializing MessageProcessingStrategy"); | ||
| return new SimpleBugStrategy(_config, workItemManager); | ||
|
|
||
| return new MultiStrategy(strategies); |
There was a problem hiding this comment.
Rather than creating a strategy to encapsulate others, can we update Mail2BugEngine's behavior to support a list of strategies instead of one. This will keep it simpler and will still support the same set of use cases. The default implementation can have only SimpleBugStrategy in the list.
| @@ -187,6 +197,22 @@ private static TempFileCollection SaveAttachments(IIncomingEmailMessage message) | |||
| return attachmentFiles; | |||
| } | |||
|
|
|||
| private IWorkItemManager InitWorkItemManager() { | |||
| IWorkItemManager workItemManager; | |||
| if (_config.TfsServerConfig.SimulationMode) | |||
There was a problem hiding this comment.
Any specific reason we need to duplicate this code here? We should rather keep this in Mail2BugEngine itself so that these classes are agnostic of which IWorkItemManager is being used.
| _ackEmailHandler = new AckEmailHandler(config); | ||
| _messageToWorkItemMapper = | ||
| new MessageToWorkItemMapper( | ||
| _config.EmailSettings.AppendOnlyEmailTitleRegex, | ||
| _config.EmailSettings.AppendOnlyEmailBodyRegex, | ||
| _workItemManager.WorkItemsCache); | ||
| } | ||
|
|
||
| public SimpleBugStrategy(Config.InstanceConfig config, IWorkItemManager WitManager) |
There was a problem hiding this comment.
Use the same variable name as the original - workItemManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding message processing strategy that can run multiple other strategies. This allows non-TFS logging of bugs. Other Mail2bug projects can add their own custom connectors enabling scenarios like logging support to storage and even creating smart responders.