Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I've just begun to investigate some weird Linux boxes, that hang
on shell.py's "try_connnect"--they absolutely should not, but them
we're talking about ancient, weird systems, like 3.x kernel--we must
guarantee that that function serves its purpose, which is to detect
Windows boxes.
When I arrived on LISA, that functionality was broken and I made it work (just to find
that these weird cases now appear, but anyhow). One internal platform
of ours totally depends on talking to Windows boxes via SSH and, well,
the nodes need to be recognized as such for things to work.
I'd like, in parallel with any fix that will come with this
investigation, to have a unit test for such functionality. My initial
thoughts were to take advantage of the Windows instance on our CI, the
OpenSSH server feature/capability of Windows 10, and have a remote
note pointing to self (localhost) in a test, then to assert that it
was marked non-POSIX.
I'd reach that by enabling the feature, editing configs to allow for
key logins, enabling/starting the service, generating keys and using
those as credentials to the node, along with user, of course. The
test, finally, would only run on Windows (preferably detecting the
ones with the service running).
Problem is that OpenSSH's situation on Windows is a clusterf*^Wvery
poorly handled, and key logins generally only work with luck.
Anyone with a better idea on how to test that or with better abilities
with Windows + OpenSSH to help me with this?
Thanks!