You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just found that the RenameParams definition is lacking the properties making it inheriting the properties of TextDocumentPositionPrams in the JSON metamodel files.
This is true both for the 3.17 and 3.18 version of the metamodel file.
I discovered this when using a tool to generate C++ objects from the LSP metamodel, this missing information breaks proper inheritance and is a bit annoying to work around.
Best regards !
While the definition of RenameParams is
interface RenameParams extends TextDocumentPositionParams,
WorkDoneProgressParams {
/**
* The new name of the symbol. If the given name is not valid the
* request must return a [ResponseError](#ResponseError) with an
* appropriate message set.
*/
newName: string;
}
The JSON description is
{
"name": "RenameParams",
"properties": [
{
"name": "textDocument",
"type": {
"kind": "reference",
"name": "TextDocumentIdentifier"
},
"documentation": "The document to rename."
},
{
"name": "position",
"type": {
"kind": "reference",
"name": "Position"
},
"documentation": "The position at which this request was sent."
},
{
"name": "newName",
"type": {
"kind": "base",
"name": "string"
},
"documentation": "The new name of the symbol. If the given name is not valid the\nrequest must return a {@link ResponseError} with an\nappropriate message set."
}
],
"mixins": [
{
"kind": "reference",
"name": "WorkDoneProgressParams"
}
],
"documentation": "The parameters of a {@link RenameRequest}."
},
See microsoft/language-server-protocol#2077 for more
details.
This commit implements the changes to fix the generated files in order to match
the LSP specification rather than the metamodel file.
Hi,
I just found that the
RenameParams
definition is lacking the properties making it inheriting the properties ofTextDocumentPositionPrams
in the JSON metamodel files.This is true both for the 3.17 and 3.18 version of the metamodel file.
I discovered this when using a tool to generate C++ objects from the LSP metamodel, this missing information breaks proper inheritance and is a bit annoying to work around.
Best regards !
While the definition of
RenameParams
isThe JSON description is
While it would be expected to have
in the
mixins
section instead oftextDocument
andposition
properties.The text was updated successfully, but these errors were encountered: