Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Abstractions] Add CancellationToken parameter in send methods in dotnet #874

Merged
merged 5 commits into from
Nov 23, 2021
Merged

[Abstractions] Add CancellationToken parameter in send methods in dotnet #874

merged 5 commits into from
Nov 23, 2021

Conversation

andrueastman
Copy link
Member

This PR updates the IRequestAdapter interface in the dotnet abstractions library to consume a CancellationToken parameter to be forwarded to the client to allow the cancelling of requests

Part of #868

@andrueastman andrueastman mentioned this pull request Nov 23, 2021
Merged
@andrueastman andrueastman marked this pull request as ready for review November 23, 2021 12:23
@andrueastman andrueastman self-assigned this Nov 23, 2021
@andrueastman andrueastman added this to the TypeWriter Replacement milestone Nov 23, 2021
@andrueastman andrueastman added the Csharp Pull requests that update .net code label Nov 23, 2021
baywet
baywet previously approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

@baywet
Merge pull request #875 from microsoft/feature/cancellationToken-http
67a9d53 
[Http] Add CancellationToken parameter in send methods in dotnet
baywet
baywet previously approved these changes Nov 23, 2021
View reviewed changes
@baywet
Merge pull request #876 from microsoft/feature/cancellationTokem
4b56db1 
[Generation] Add CancellationToken parameter in send methods in dotnet
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit 232ee67 into main Nov 23, 2021
@baywet baywet deleted the feature/cancellationToken-abstractions branch November 23, 2021 16:02
@andrueastman andrueastman mentioned this pull request Nov 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@peombwa peombwa Awaiting requested review from peombwa

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@zengin zengin Awaiting requested review from zengin

Assignees

@andrueastman andrueastman

Labels
Csharp Pull requests that update .net code
Projects
None yet
Milestone
TypeWriter Replacement
Development

Successfully merging this pull request may close these issues.
2 participants
@andrueastman @baywet