Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Samwelkanda/python requests request adapter #1251

Merged
merged 19 commits into from
Mar 1, 2022
Merged

Samwelkanda/python requests request adapter #1251

merged 19 commits into from
Mar 1, 2022

Conversation

samwelkanda
Copy link
Contributor

@samwelkanda samwelkanda commented Feb 22, 2022 •
edited
Loading

Adds a HTTPRequestAdapter implementation for python's requests library

closes #1158

baywet
baywet reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting the work here, a few comments to help

http/python/requests/http/requests/middleware/options/retry_handler_option.py Outdated Show resolved Hide resolved
http/python/requests/http/requests/middleware/options/retry_handler_option.py Outdated Show resolved Hide resolved
http/python/requests/http/requests/requests_request_adapter.py Outdated Show resolved Hide resolved
@samwelkanda samwelkanda force-pushed the samwelkanda/python-requests-request-adapter branch from 0403864 to e4a64be Compare February 28, 2022 21:08
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@samwelkanda samwelkanda marked this pull request as ready for review February 28, 2022 21:13
@samwelkanda samwelkanda requested a review from baywet March 1, 2022 10:19
@samwelkanda samwelkanda self-assigned this Mar 1, 2022
@samwelkanda samwelkanda added this to the Community Preview milestone Mar 1, 2022
baywet
baywet approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the great work!

.github/workflows/http-python-requests.yml Show resolved Hide resolved
@samwelkanda samwelkanda merged commit 4a4750c into main Mar 1, 2022
@samwelkanda samwelkanda deleted the samwelkanda/python-requests-request-adapter branch March 1, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman Awaiting requested review from andrueastman

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@peombwa peombwa Awaiting requested review from peombwa

@nikithauc nikithauc Awaiting requested review from nikithauc

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

Assignees

@samwelkanda samwelkanda

Labels
Python
Projects
None yet
Milestone
Community Preview
Development

Successfully merging this pull request may close these issues.

error handling in python request adapter
2 participants
@samwelkanda @baywet