- updates parameters names to make it explicit

Signed-off-by: Vincent Biret <[email protected]>

http/go/nethttp/redirect_handler.go

@@ -51,23 +51,23 @@ type redirectHandlerOptionsInt interface {
 }
 
 // Returns the key value to be used when the option is added to the request context
-func (o *RedirectHandlerOptions) GetKey() abs.RequestOptionKey {
+func (options *RedirectHandlerOptions) GetKey() abs.RequestOptionKey {
 	return redirectKeyValue
 }
 
 // Returns the redirection evaluation function.
-func (o *RedirectHandlerOptions) GetShouldRedirect() func(req *nethttp.Request, res *nethttp.Response) bool {
-	return o.ShouldRedirect
+func (options *RedirectHandlerOptions) GetShouldRedirect() func(req *nethttp.Request, res *nethttp.Response) bool {
+	return options.ShouldRedirect
 }
 
 // Returns the maximum number of redirects to follow.
-func (o *RedirectHandlerOptions) GetMaxRedirect() int {
-	if o == nil || o.MaxRedirects < 1 {
+func (options *RedirectHandlerOptions) GetMaxRedirect() int {
+	if options == nil || options.MaxRedirects < 1 {
 		return defaultMaxRedirects
-	} else if o.MaxRedirects > absoluteMaxRedirects {
+	} else if options.MaxRedirects > absoluteMaxRedirects {
 		return absoluteMaxRedirects
 	} else {
-		return o.MaxRedirects
+		return options.MaxRedirects
 	}
 }
 

http/go/nethttp/retry_handler.go

@@ -58,34 +58,34 @@ var retryKeyValue = abs.RequestOptionKey{
 }
 
 // Returns the key value to be used when the option is added to the request context
-func (o *RetryHandlerOptions) GetKey() abs.RequestOptionKey {
+func (options *RetryHandlerOptions) GetKey() abs.RequestOptionKey {
 	return retryKeyValue
 }
 
 // Returns the should retry callback function
-func (o *RetryHandlerOptions) GetShouldRetry() func(delay time.Duration, executionCount int, request *nethttp.Request, response *nethttp.Response) bool {
-	return o.ShouldRetry
+func (options *RetryHandlerOptions) GetShouldRetry() func(delay time.Duration, executionCount int, request *nethttp.Request, response *nethttp.Response) bool {
+	return options.ShouldRetry
 }
 
 // Returns the delays in seconds between retries
-func (o *RetryHandlerOptions) GetDelaySeconds() int {
-	if o.DelaySeconds < 1 {
+func (options *RetryHandlerOptions) GetDelaySeconds() int {
+	if options.DelaySeconds < 1 {
 		return defaultDelaySeconds
-	} else if o.DelaySeconds > absoluteMaxDelaySeconds {
+	} else if options.DelaySeconds > absoluteMaxDelaySeconds {
 		return absoluteMaxDelaySeconds
 	} else {
-		return o.DelaySeconds
+		return options.DelaySeconds
 	}
 }
 
 // Returns the maximum number of times a request can be retried
-func (o *RetryHandlerOptions) GetMaxRetries() int {
-	if o.MaxRetries < 1 {
+func (options *RetryHandlerOptions) GetMaxRetries() int {
+	if options.MaxRetries < 1 {
 		return defaultMaxRetries
-	} else if o.MaxRetries > absoluteMaxRetries {
+	} else if options.MaxRetries > absoluteMaxRetries {
 		return absoluteMaxRetries
 	} else {
-		return o.MaxRetries
+		return options.MaxRetries
 	}
 }