refactor(nethttp_request_adapter.go): As of Go 1.16, the functions in the ioutil package have been deprecated. #137
+15
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as deprecated As of Go 1.16, ioutil.ReadAll was deprecated.
XdpCs
requested review from
andrueastman,
baywet,
zengin,
MIchaelMainer,
peombwa,
calebkiage and
rkodev
as code owners
fix ioutil
revert parameters_name_decoding_handler_test.go
XdpCs
changed the title
XdpCs
changed the title
update CHANGELOG.md
andrueastman
previously approved these changes
Jan 22, 2024
rkodev
previously approved these changes
Jan 22, 2024
baywet
reviewed
Jan 22, 2024
baywet
dismissed stale reviews from rkodev, andrueastman, and themself
via
dea4d65
baywet
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Go 1.16, ioutil.ReadAll, ioutil.NopCloser were deprecated.