Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update request_information.go #173

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Update request_information.go #173

merged 1 commit into from
Jul 9, 2024

Conversation

gu-colin-morris
Copy link
Contributor

Typo correction for content type:

  • "application/octet-stream" replacing "application/octet-steam"

@gu-colin-morris
Update request_information.go
b64631a 
Typo correction for content type:
 - "application/octet-stream" replacing "application/octet-steam"
@gu-colin-morris gu-colin-morris requested a review from a team as a code owner July 8, 2024 05:03
andrueastman
andrueastman reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @gu-colin-morris

Any chance you could add a changelog entry for the same with a patch version number update?

https://github.com/microsoft/kiota-abstractions-go/blob/main/CHANGELOG.md

@gu-colin-morris
Copy link
Contributor Author

Sure can. I've found another of the "octet-steam" entries, do you want that in the same patch commit?

@gu-colin-morris
Copy link
Contributor Author

Sure can. I've found another "octet-steam" - do you want that in the same patch? (assuming 1.8.1)

@andrueastman
Copy link
Member

Sure thing. We can have them all together.

Sure can. I've found another "octet-steam" - do you want that in the same patch? (assuming 1.8.1)

@andrueastman andrueastman mentioned this pull request Jul 9, 2024
Merged
@andrueastman andrueastman merged commit 1df8523 into microsoft:main Jul 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@SilasKenneth SilasKenneth SilasKenneth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gu-colin-morris @andrueastman @SilasKenneth