Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personal/wiyochum/arm deployment event batching #83

Conversation

wi-y
Copy link
Contributor

@wi-y wi-y commented Dec 16, 2020

This PR contains a script and an ARM template for deploying the IoMT Connector as Azure WebJobs.

Will point this PR to master, or merge this PR into my existing SA replacement branch depending on sign off timing.

Function BuildPackage() {
try {
Push-Location $currentPath
cd ../../src/console/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: do we assume that the script is being executed at a specific location, like "deploy/scripts/"? is that possible to set a working directory with dotnet?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be better to just resolve the path and build against it if possible. Changing directory and keeping target can get tricky.


In reply to: 544493385 [](ancestors = 544493385)

Copy link
Contributor

@ms-teli ms-teli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall look good to me, it would be helpful to see some testing output of the scripts.

@@ -0,0 +1,604 @@
{
"$schema": "http://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$schema [](start = 3, length = 7)

We can have a separate template for now but ideally I would like to collapse this and others into one template with conditionals. We have many different flavors of ARM templates today and they are becoming harder to manage and keep in sync with changes.

"redundancyMode": "None"
}
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So using the setting "PROJECT": "relative path to webjob project here" +
{
"apiVersion": "2015-08-01",
"name": "web",
"type": "sourcecontrols",
"condition": "[variables('deploy_source_code')]",
"dependsOn": [
"[variables('app_service_resource_id')]",
"[resourceId('Microsoft.Web/sites/config', variables('app_service_name'), 'appsettings')]"
],
"properties": {
"RepoUrl": "[parameters('RepositoryURL')]",
"branch": "[parameters('RepositoryBranch')]",
"IsManualIntegration": true
}
}

doesn't work for web jobs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it could work since webjobs appear to only care about the file names and locations of the files.

I'll try a few things today but if it doesn't work I'll create a future work item to investigate trying to get rid of the script and try using only arm templates for deploying the webjobs.

Copy link
Member

@dustinburson dustinburson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@wi-y wi-y merged commit 4d006ae into personal/wiyochum/event-hub-read-and-batch Jan 6, 2021
@dustinburson dustinburson deleted the personal/wiyochum/arm-deployment-event-batching branch November 8, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants