Fixed issue where bundle extension could return null when resource exists #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiquidPT
reviewed
Jan 3, 2020
test/Microsoft.Health.Extensions.Fhir.R4.UnitTests/BundleExtensionsTests.cs
Outdated
Show resolved
Hide resolved
LiquidPT
approved these changes
Jan 3, 2020
dustinburson
reviewed
Jan 6, 2020
|
|
||
| var resources = await bundle?.ReadFromBundleWithContinuationAsync<TResource>(fhirClient, 2); | ||
|
|
||
| var resourceCount = resources.Count(); |
There was a problem hiding this comment.
Minor, but best to use .ToArray to avoid multiple enumerations over the same collection (happens with Count & FirstOrDefault). Impact is minimal since ReadFromBundleWithContinuation is using a materialized collection behind the scenes (list in this case) but if that ever changes we should re-evaluate.
We also may want to look at using async enumerables going forward as well https://docs.microsoft.com/en-us/archive/msdn-magazine/2019/november/csharp-iterating-with-async-enumerables-in-csharp-8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A condition exists, where, a search request can return an empty bundle with a continuation token. The ReadOneFromBundle method assumed that if any Resource meeting the search criteria was found, the first bundle returned would contain at least one resource.
These changes include: