Host R4 Templates inside of own project #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogordon01
commented
Mar 11, 2022
| @@ -8,7 +8,7 @@ | |||
| using EnsureThat; | |||
| using Hl7.Fhir.Model; | |||
|
|
|||
| namespace Microsoft.Health.Extensions.Fhir | |||
| namespace Microsoft.Health.Fhir.R4.Ingest.Templates.Extensions | |||
There was a problem hiding this comment.
The project where this file was hosted currently targets net6.0. Since these methods are only used by the R4 templates I moved this class into the new Health.Fhir.R4.Ingest.Tempates project.
dustinburson
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The R4 Templates are required inside of our provisioning service. This PR moves the R4 Templates inside of their own project which targets netstandard2.0.