-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve retry logic to handle invalid cache and no changes to Observation #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogordon01
requested changes
Jan 25, 2022
src/lib/Microsoft.Health.Fhir.R4.Ingest/Service/R4FhirImportService.cs
Outdated
Show resolved
Hide resolved
src/lib/Microsoft.Health.Fhir.R4.Ingest/Service/R4FhirImportService.cs
Outdated
Show resolved
Hide resolved
src/lib/Microsoft.Health.Fhir.R4.Ingest/Service/R4FhirImportService.cs
Outdated
Show resolved
Hide resolved
src/lib/Microsoft.Health.Fhir.R4.Ingest/Service/R4FhirImportService.cs
Outdated
Show resolved
Hide resolved
src/lib/Microsoft.Health.Fhir.R4.Ingest/Service/R4FhirImportService.cs
Outdated
Show resolved
Hide resolved
src/lib/Microsoft.Health.Fhir.R4.Ingest/Service/R4FhirImportService.cs
Outdated
Show resolved
Hide resolved
src/lib/Microsoft.Health.Fhir.R4.Ingest/Service/R4FhirImportService.cs
Outdated
Show resolved
Hide resolved
dustinburson
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions to optimize but overall the changes look good.
rogordon01
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes updates to the R4FhirImportService SaveObservationAsync logic.
Invalid cache entry:
If an Observation has been saved to the in memory cache and deleted from the FHIR server, it may take an hour for the cache to be updated. During this time, when new data is sent, PUT operations on the deleted Observation will fail. These code updates will handle the failure by removing the invalid Observation from the cache, creating a new Observation in the FHIR server, and saving the new Observation to the cache.
Observations updated repeatedly:
If a batch of data contains one or more messages that can successfully be transformed into Observations, but also contains one or more messages that will cause an "unhandled" exception, the entire batch will be retried indefinitely. The retry will include updating the successful Observations in the FHIR Server repeatedly. These code updates will check the new Observation with the existing Observation and only perform a PUT if there is a change. This will prevent unnecessary updates to Observations, and reduce requests to the FHIR Server.