Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug 86283]: Add "Codes" Validation to FHIR Mapping #147

Merged
merged 4 commits into from
Nov 22, 2021
Merged

[Bug 86283]: Add "Codes" Validation to FHIR Mapping #147

merged 4 commits into from
Nov 22, 2021

Conversation

kenziedolish
Copy link
Contributor

@kenziedolish kenziedolish commented Nov 17, 2021 •
edited
Loading

Issue: Bug 86283

Purpose of PR: Add to template validation a check to make sure the code is defined on FHIR mappings

Code Changes:

  • updated CodeValueFhirTemplate.cs and CodeValueMapping.cs by making "Codes" a required field
  • added GivenInvalidTemplateJsonMissingCodeField_WhenFactoryCreate_ThenTemplateCreated_Test and input file to test that template validation exception is thrown when "Codes" is missing
  • updated GivenValidTemplateJsonWithValueStringType test and input

@kenziedolish kenziedolish marked this pull request as ready for review November 17, 2021 17:13
@kenziedolish kenziedolish requested a review from a team as a code owner November 17, 2021 17:13
dustinburson
dustinburson requested changes Nov 17, 2021
View reviewed changes
Copy link
Member

@dustinburson dustinburson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need to remove the changes to require codes on the codeable concept class (and the value type that inherits from it) to conform with the FHIR specification.

@kenziedolish kenziedolish merged commit f660a25 into master Nov 22, 2021
@kenziedolish kenziedolish deleted the personal/mdolishny/fhir-mapping-code-error branch November 22, 2021 22:38
@pallar-ms
Copy link
Contributor

Sorry late to this PR - but do we want to also check if the code value is not null or empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustinburson dustinburson dustinburson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenziedolish @pallar-ms @dustinburson