Added option to allow setting DNS search list for containers #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowenna
reviewed
Jan 4, 2017
| @@ -65,6 +65,7 @@ type ContainerConfig struct { | |||
| HvRuntime *HvRuntime `json:",omitempty"` // Hyper-V container settings. Used by Hyper-V containers only. Format ImagePath=%root%\BaseLayerID\UtilityVM | |||
| Servicing bool // True if this container is for servicing | |||
| AllowUnqualifiedDNSQuery bool // True to allow unqualified DNS name resolution | |||
| DNSSearchList string // List of DNS suffixes to use for resolution | |||
There was a problem hiding this comment.
Would it be better to have this as an array?
There was a problem hiding this comment.
It probably would have been a better option. However, I have already done the platform work for this and have it as a comma separated string there :(. I also don't expect this to change.
There was a problem hiding this comment.
K. Perhaps you could comment on there that it's a comma separated list.
There was a problem hiding this comment.
Ok adding the comment.
Signed-off-by: msabansal <[email protected]>
|
@jhowardmsft PTAL |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNSSearchList allows us to set DNS suffixes for containers. This is required to support --dns-search docker option.
Signed-off-by: msabansal [email protected]