Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statistics query #59

Merged
merged 1 commit into from
Aug 9, 2016
Merged

Add statistics query #59

merged 1 commit into from
Aug 9, 2016

Conversation

lowenna
Copy link
Contributor

@lowenna lowenna commented Aug 8, 2016

Signed-off-by: John Howard [email protected]

@darrenstahlmsft

@darstahl
Copy link
Contributor

darstahl commented Aug 9, 2016

On second thought, do we want to expose the raw JSON string through this interface, or should we wrap it with methods such as GetCurrentMemory(), etc. Similar to the way that AreUpdatesPending() wraps the internal properties() call?

Edit: At the very least, I think this should return a scruct with the Statistics instead of raw JSON.

@lowenna
Copy link
Contributor Author

lowenna commented Aug 9, 2016

Possibly. Not sure yet. Will take a look in the morning

Signed-off-by: John Howard <[email protected]>
@lowenna
Copy link
Contributor Author

lowenna commented Aug 9, 2016

@darrenstahlmsft Updated with struct and verified that the call returns data.

@darstahl
Copy link
Contributor

darstahl commented Aug 9, 2016

LGTM

@darstahl darstahl merged commit a799400 into master Aug 9, 2016
@lowenna lowenna deleted the jjh/statistics branch August 9, 2016 21:14
dcantah pushed a commit to dcantah/hcsshim that referenced this pull request Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants