Add and updateCodeQL suppression #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiashok
approved these changes
Aug 23, 2024
katiewasnothere
approved these changes
Aug 26, 2024
ambarve
approved these changes
Aug 27, 2024
Microsoft CodeQL analyzer's suppression format is slightly different than GitHub's, and expects the suppression comment to be one line. Update suppression comments in `pkg\ociwclayer\import.go` to conform. Suppress warnings for "uncontrolled process operation" in `init\init.c` and `vsockexec\vsockexec.c`. Suppress "incorrect conversion between integer types" in `internal\jobobject\limits.go`, and add fix to `internal\guest\runtime\hcsv2\uvm.go`. Signed-off-by: Hamza El-Saawy <[email protected]>
helsaawy
force-pushed
the
codeql-comment
branch
from
740e632 to
ff9172e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft CodeQL analyzer's suppression format is slightly different than GitHub's, and expects the suppression comment to be one line. Update suppression comments in
pkg\ociwclayer\import.goto conform.Suppress warnings for "uncontrolled process operation" in
init\init.candvsockexec\vsockexec.c.Suppress "incorrect conversion between integer types" in
internal\jobobject\limits.go, and add fix tointernal\guest\runtime\hcsv2\uvm.go.