Update JOB_OBJECT_ALL_ACCESS and OpenJobObject
#2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `JOB_OBJECT_ALL_ACCESS` value to the most recent one. Update `winapi.OpenJobObject` to accept `inheritHandle` as `bool` as the documentation suggests. Signed-off-by: Maksim An <[email protected]>
|
What is the documentation that suggests we change to passing |
I wanted to make sure that the type matches to what's in the docs: https://learn.microsoft.com/en-us/windows/win32/api/jobapi2/nf-jobapi2-openjobobjectw. The underlying syscall doesn't change, and with the change we won't need to convert |
|
It looks like the syscall code handles this just fine. Just wanted to be clear that in general, Windows |
helsaawy
reviewed
Apr 2, 2024
helsaawy
approved these changes
Apr 2, 2024
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Update `JOB_OBJECT_ALL_ACCESS` value to the most recent one. Update `winapi.OpenJobObject` to accept `inheritHandle` as `bool`. The underlying syscall stays the same, but this allows cleaner calls from go's perspective as it avoids `bool` to `uint32` casting. Signed-off-by: Maksim An <[email protected]>
kiashok
pushed a commit
to kiashok/hcsshim
that referenced
this pull request
Oct 29, 2024
Update `JOB_OBJECT_ALL_ACCESS` value to the most recent one. Update `winapi.OpenJobObject` to accept `inheritHandle` as `bool`. The underlying syscall stays the same, but this allows cleaner calls from go's perspective as it avoids `bool` to `uint32` casting. Signed-off-by: Maksim An <[email protected]> (cherry picked from commit 42671b4) Signed-off-by: Kirtana Ashok <[email protected]>
kiashok
pushed a commit
that referenced
this pull request
Oct 30, 2024
Update `JOB_OBJECT_ALL_ACCESS` value to the most recent one. Update `winapi.OpenJobObject` to accept `inheritHandle` as `bool`. The underlying syscall stays the same, but this allows cleaner calls from go's perspective as it avoids `bool` to `uint32` casting. Signed-off-by: Maksim An <[email protected]> (cherry picked from commit 42671b4) Signed-off-by: Kirtana Ashok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
JOB_OBJECT_ALL_ACCESSvalue to the most recent one.Update
winapi.OpenJobObjectto acceptinheritHandleasboolas the documentation suggests.