Add tool to install modules in lcow and plumb through shim #1195
Conversation
katiewasnothere
force-pushed
the
lcow_install_modules
branch
from
7065f1f
to
083b6a6
Compare
| for _, driver := range args { | ||
| modules := []string{} | ||
|
|
||
| driverGUID, err := uuid.NewRandom() |
There was a problem hiding this comment.
Is this new dep only because go-winio/pkg/guid doesn't build on Linux? 😔 microsoft/go-winio#169 We should move this forward, I'll approve and we should get a new release of go-winio out with this, didn't realize this (or know about that pr) until now. We shouldn't have to bring in a new dep for this.
There was a problem hiding this comment.
Ok now that that's in, we'll just need to cut a release and revendor here
There was a problem hiding this comment.
Did we come to a conclusion on cutting a new tag?
There was a problem hiding this comment.
I don't think so, but since this is an official google package I'd think the risk is probably minimal either way.
There was a problem hiding this comment.
Not worried about risk, more that we're introducing a new dep just to generate an ID when a project we maintain has the same functionality (if we cut a new tag) haha
There was a problem hiding this comment.
Let's just do a follow up pr to remove the dep with a new tag of winio so we can move this forward
katiewasnothere
force-pushed
the
lcow_install_modules
branch
from
083b6a6
to
40b9ec6
Compare
|
@katiewasnothere Can you push new commits when addressing feedback so it's easier to review on github? We can just squash at the end |
Signed-off-by: Kathryn Baldauf <[email protected]>
Signed-off-by: Kathryn Baldauf <[email protected]>
katiewasnothere
force-pushed
the
lcow_install_modules
branch
from
40b9ec6
to
9ed0296
Compare
internal/devices/pnp.go
Outdated
| @@ -61,3 +66,72 @@ func execPnPInstallDriver(ctx context.Context, vm *uvm.UtilityVM, driverDir stri | |||
| log.G(ctx).WithField("added drivers", driverDir).Debug("installed drivers") | |||
| return nil | |||
| } | |||
|
|
|||
| func execModprobeInstallDriver(ctx context.Context, vm *uvm.UtilityVM, driverDir string) error { | |||
There was a problem hiding this comment.
Move LCOW install support routines out of pnp.go
…river Signed-off-by: Kathryn Baldauf <[email protected]>
Related work items: microsoft#1067, microsoft#1097, microsoft#1119, microsoft#1170, microsoft#1176, microsoft#1180, microsoft#1181, microsoft#1182, microsoft#1183, microsoft#1184, microsoft#1185, microsoft#1186, microsoft#1187, microsoft#1188, microsoft#1189, microsoft#1191, microsoft#1193, microsoft#1194, microsoft#1195, microsoft#1196, microsoft#1197, microsoft#1200, microsoft#1201, microsoft#1202, microsoft#1203, microsoft#1204, microsoft#1205, microsoft#1206, microsoft#1207, microsoft#1209, microsoft#1210, microsoft#1211, microsoft#1218, microsoft#1219, microsoft#1220, microsoft#1223
…odules Add tool to install modules in lcow and plumb through shim
This PR adds support to install modules in LCOW. When drivers are specified on the pod or container config, the shim will make a request in the LCOW UVM to run the new tool
install-driverswhich creates a new mount location for the driver files and installs all driver modules usingdepmodandmodprobe.Signed-off-by: Kathryn Baldauf [email protected]