Update ncproxy compute agent cache map #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevpar btw |
kevpar
reviewed
Aug 24, 2021
| // GRPC service exposed for use by a Node Network Service. | ||
| type grpcService struct{} |
There was a problem hiding this comment.
Side note: I would love if in the future we can find better names for the "network agent facing" and "shim facing" services than grpcService and ttrpcService.
kevpar
reviewed
Aug 24, 2021
katiewasnothere
force-pushed
the
container_id_to_compute_agent_sync
branch
from
705cd57 to
8ce13ee
Compare
kevpar
reviewed
Aug 24, 2021
…it a sync map Signed-off-by: Kathryn Baldauf <[email protected]>
katiewasnothere
force-pushed
the
container_id_to_compute_agent_sync
branch
from
8ce13ee to
3af4cb6
Compare
dcantah
approved these changes
Aug 25, 2021
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#930, microsoft#962, microsoft#1004, microsoft#1008, microsoft#1039, microsoft#1045, microsoft#1046, microsoft#1047, microsoft#1052, microsoft#1053, microsoft#1054, microsoft#1057, microsoft#1058, microsoft#1060, microsoft#1061, microsoft#1063, microsoft#1064, microsoft#1068, microsoft#1069, microsoft#1070, microsoft#1071, microsoft#1074, microsoft#1078, microsoft#1079, microsoft#1081, microsoft#1082, microsoft#1083, microsoft#1084, microsoft#1088, microsoft#1090, microsoft#1091, microsoft#1093, microsoft#1094, microsoft#1096, microsoft#1098, microsoft#1099, microsoft#1102, microsoft#1103, microsoft#1105, microsoft#1106, microsoft#1108, microsoft#1109, microsoft#1115, microsoft#1116, microsoft#1122, microsoft#1123, microsoft#1126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the global version of the compute agent cache in favor of a map shared by the grpc and ttrpc service with synchronization using a read write lock.
Signed-off-by: Kathryn Baldauf [email protected]