Prevent data race when closing active file

[mlaventure]

The race usually happens when closeHandle() and prepareIo() are called
concurrently; the former tries to set closing to true the latter tries
to read its value.

In order to avoid this issue, we added a lock around the variable.

Signed-off-by: Kenfe-Mickael Laventure [email protected]

[msftclas]

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

[mlaventure]

Just realized that both #31 and #59 are proposed fix for this 😅

Feel free to close if any of them is merged.

[darstahl]

I also left this same comment in #59, but:

We already have an "atomicBool" type in this file used for a different bool with a similar issue. I'd prefer to use that instead of adding a Mutex.

type atomicBool int32

func (b *atomicBool) isSet() bool { return atomic.LoadInt32((*int32)(b)) != 0 }
func (b *atomicBool) setFalse()   { atomic.StoreInt32((*int32)(b), 0) }
func (b *atomicBool) setTrue()    { atomic.StoreInt32((*int32)(b), 1) }

See deadlineHandler.timedout for example usage.

I've confirmed that this makes the race detector happy.

[mlaventure]

@darrenstahlmsft updated, used a compare-and-swap for setting closing to true though.

[darstahl]

#59 was merged, so I'm closing this. Thanks though!

[mlaventure]

Thanks, any timeline on a 0.4.4 release?

On Tue, Jul 25, 2017, 12:08 AM Darren Stahl ***@***.***> wrote: Closed #60 <#60>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APUifkOa35DMZFmUwaXq9KiCDbWswDWFks5sRWpSgaJpZM4Oc962> .

-- Sent from my phone.

[darstahl]

I merged that on my phone last night, taking v0.4.4 right now.