Assign ErrPipeListenerClosed to net.ErrClosed #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error used to just be a `errors.New` with the text exactly matching the "use of closed network connection" that you'd get from the Go stdlib. Now that that error was exported as `net.ErrClosed` in Go 1.16 we should be able to swap to this safely, and anyone who relied on checking the string explicitly should still be fine. Signed-off-by: Daniel Canter <[email protected]>
|
CI's using Go 1.15.5 and that's the reason for the fail, will look in a little. Edit: Our tests didn't specify a go-version, fixed. |
Add in a ^1.17.0 go-version for the actions/setup-go@v2 action. This was set for our build step but not for the step that runs all of the unit tests. Signed-off-by: Daniel Canter <[email protected]>
helsaawy
approved these changes
Apr 6, 2022
|
@thaJeztah I could only see here where moby was making use of this, and it seems like the usage would continue working. Maybe our comment was out of date 🤷♂️ https://github.com/moby/moby/blob/7b9275c0da707b030e62c96b679a976f31f929d3/libcontainerd/remote/client_io_windows.go#L84-L86. There's these two spots that check the error text but they're both using tcp/http conns, so not really relevant. |
|
fyi @katiewasnothere @ambarve as I think we'd talked about this before |
|
@katiewasnothere @ambarve Anybody able to give this a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error used to just be a
errors.Newwith the text exactly matching the "use of closed network connection" that you'd get from the Go stdlib. Now that that error was exported asnet.ErrClosedin Go 1.16 we shouldbe able to swap to this safely.