Handle upstream 1.21.0 change to have zero in tag #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
approved these changes
May 16, 2023
I realized this isn't true: if this change goes wrong, we can simply create a release update PR manually and feed that into automation for the next attempt. (And then fix it later for the next release.) Very low risk. |
chsienki
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.0third digit in major releases go#888Upstream has this set up to apply at 1.21.0, so put that in our infra. This is called by the part of release automation that polls the upstream repo on release day. If it doesn't end up working out for some reason, we'll need to revert this PR and re-run automation.
I considered polling both the old and new formats at the same time, but I would prefer to simply get it right rather than add a tag check race. I haven't seen any indication that upstream would go back to the old versioning scheme if something went wrong, so I don't know if it would actually end up being used even in that case.